feat(HMS-1772): Allow selecting custom resource group #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
commented
Oct 5, 2023
| const queryClient = new QueryClient({ | ||
| logger: { | ||
| log: console.log, | ||
| warn: console.warn, | ||
| // ✅ no more errors on the console | ||
| error: () => {}, | ||
| }, | ||
| defaultOptions: { | ||
| queries: { | ||
| retry: queryRetries, |
There was a problem hiding this comment.
This is good practice in tests to have easier time to test for failures.
ezr-ondrej
force-pushed
the
azure_resource_group
branch
from
ac8e7ce to
7df98f6
Compare
|
Nice. |
|
Ah, this would require wizard changes in QE tests since we have a new dropdown. |
|
/retest |
1 similar comment
|
/retest |
|
@ezr-ondrej Can please you rebase this? Thanks! |
ezr-ondrej
force-pushed
the
azure_resource_group
branch
from
7df98f6 to
5eb2d8b
Compare
rebased! :) I think that only now we will run the Azure tests, right? |
akhil-jha
approved these changes
Oct 17, 2023
|
I'll go ahead and self merge, I promise to fix any issues that may arrise, but at least now we've tested this with Azure tests on :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2023-10-05.20-27-33.webm
Simple and straightforward I hope :)
UI part for RHEnVision/provisioning-backend#694
Update your backend env or test with stage! :)