Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add descriptions to all tags #738

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ezr-ondrej
Copy link
Member

@ezr-ondrej ezr-ondrej commented Oct 27, 2023

Add descriptions to tags, as some libraries read the tags from tag list only.

Also moves the availability endpoint to Source tag, as it felt kinda lonely in the tag by itself and Source felt like a good home for it :)

For example RH api-catalog:

image

@ezr-ondrej ezr-ondrej requested a review from a team as a code owner October 27, 2023 16:32
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lzap
Copy link
Member

lzap commented Oct 31, 2023

iqe_provisioning_api.exceptions.ApiAttributeError: V1AWSReservationResponseDetail has no attribute 'public_ipv4' at ['['received_data', 'instances', 0, 'detail']']['public_ipv4']

/retest

@ezr-ondrej
Copy link
Member Author

🍏 Looks like some glitch - missing public_ipv4 quota, I guess we should keep the empty value for it 🤔

@ezr-ondrej ezr-ondrej merged commit 6e22b52 into RHEnVision:main Oct 31, 2023
6 checks passed
@ezr-ondrej ezr-ondrej deleted the reservations_tag branch October 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants