-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HMS-2640): machine type is required #734
Conversation
/retest |
This seems to be unrelated to what you're fixing 🤔 Is this really fixing it? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are probably typos in the examples, but I do not understand this patch 🤔
"source_id": "{{source_id_gcp}}", | ||
"image_id": "https://www.googleapis.com/compute/v1/projects/rhel-cloud/global/images/rhel-9-v20230411", | ||
"amount": 1, | ||
"machine_type": "e2-micro", | ||
"launch_template_id": "{{launch_template_id}}", | ||
"launch_template_id_gcp": "{{launch_template_id}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"launch_template_id_gcp": "{{launch_template_id}}", | |
"launch_template_id": "{{launch_template_id_gcp}}", |
@@ -8,7 +8,7 @@ X-Rh-Identity: {{identity}} | |||
"source_id": "{{source_id_aws}}", | |||
"image_id": "ami-05fa00d4c63e32376", | |||
"amount": 1, | |||
"launch_template_id": "{{launch_template_id}}", | |||
"launch_template_id_aws": "{{launch_template_id}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"launch_template_id_aws": "{{launch_template_id}}", | |
"launch_template_id": "{{launch_template_id_aws}}", |
Exactly, however, this is what Google returns. You pass nothing - this error. You pass any valid value and there you have it. It is weird indeed, I am fine just ignoring this it might be only on our account. |
Signed-off-by: Lukas Zapletal <[email protected]>
8f2c413
to
0cb34c1
Compare
Hmm I've got no idea really, but this PR defies purpose of the previous change: https://github.com/RHEnVision/provisioning-backend/pull/686/files#diff-91dda804d58381d894991796abaf5e1d17a6c2616438e44eaffa239494428605R217 So if we want to backtrack on that, we should also revert that to stay consistent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a typo, we did not rename the parameters, right?
@@ -8,7 +8,7 @@ X-Rh-Identity: {{identity}} | |||
"source_id": "{{source_id_aws}}", | |||
"image_id": "ami-05fa00d4c63e32376", | |||
"amount": 1, | |||
"launch_template_id": "{{launch_template_id}}", | |||
"launch_template_id_aws": "{{launch_template_id_aws}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"launch_template_id_aws": "{{launch_template_id_aws}}", | |
"launch_template_id": "{{launch_template_id_aws}}", |
"source_id": "{{source_id_gcp}}", | ||
"image_id": "https://www.googleapis.com/compute/v1/projects/rhel-cloud/global/images/rhel-9-v20230411", | ||
"amount": 1, | ||
"machine_type": "e2-micro", | ||
"launch_template_id": "{{launch_template_id}}", | ||
"launch_template_id_gcp": "{{launch_template_id_gcp}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"launch_template_id_gcp": "{{launch_template_id_gcp}}", | |
"launch_template_id": "{{launch_template_id_gcp}}", |
Yeah let’s keep it as is. |
It looks like GCP errors out with "Operation denied by custom org policy: [customConstraints/custom.denyMachineTypes] : This organization policy prevents creating instances with exotic machine types. Contact the IT Public Cloud team at help.redhat.com for an exception" when nothing is passed into machine type. It is likely only on our account, but I am unable to test this with different account so making the field a required field.
Replaces: #689