Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HMS-2830): Add resource group to Azure response #727

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ezr-ondrej
Copy link
Member

@ezr-ondrej ezr-ondrej commented Oct 18, 2023

We have missed adding Resource Group to the response in b369cf8.

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. Merging.

@lzap
Copy link
Member

lzap commented Oct 18, 2023

iqe_provisioning_api.exceptions.ApiAttributeError: V1AzureReservationResponse has no attribute 'resource_group' at ['received_data']['resource_group']

We need to do an IQE refresh, let me learn how to do it.

@lzap
Copy link
Member

lzap commented Oct 19, 2023

/retest

IQE merged

@ezr-ondrej
Copy link
Member Author

/retest

Maybe the new IQE version was not published properly yet :)

@akhil-jha
Copy link
Member

You'd need a rebase I believe

@ezr-ondrej
Copy link
Member Author

You'd need a rebase I believe

For the new account? I think the pipeline rebases the PR automatically 🤔 let see :)

We have misseadding Resource Group to the response in b369cf8.
@ezr-ondrej ezr-ondrej force-pushed the resource_group_response branch from 9d6976e to c51f29b Compare October 19, 2023 11:00
@akhil-jha
Copy link
Member

My comment on HMS-2830 needs to be completed first. 🤦

@lzap
Copy link
Member

lzap commented Oct 19, 2023

TypeError: init() got an unexpected keyword argument 'resource_group'

@ezr-ondrej
Copy link
Member Author

/retest

@akhil-jha akhil-jha merged commit 8a733b2 into RHEnVision:main Oct 19, 2023
6 checks passed
@ezr-ondrej ezr-ondrej deleted the resource_group_response branch October 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants