chore: use OTLP instead of Jaeger exporter #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
force-pushed
the
fix-stats
branch
2 times, most recently
from
145e093 to
6801e87
Compare
Signed-off-by: Lukáš Zapletal <[email protected]>
ezr-ondrej
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactoring of tracing - we had to move from deprecated Jaeger exporter to OTLP exporter. With that, a small improvement - all errors of the tracing library now go into our Zerolog (thus platform logs). This works great, tested. However, I do not have Jaeger installed anymore, can you test it actually works @ezr-ondrej please?
FYI I renamed config group so now it should be:
This needs to be merged before we can upgrade deps: #722