Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert workaround for CVE-2023-44487 #713

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 12, 2023

Do not merge yet.

This is a PR to remind us we need to revert this workaround in the future.

@lzap lzap force-pushed the cve-2023-44487-rev branch from cdaf1a0 to 32c7ab9 Compare October 23, 2023 09:54
@lzap
Copy link
Member Author

lzap commented Oct 23, 2023

Rebased, we can merge this one now @ezr-ondrej

@ezr-ondrej
Copy link
Member

/retest

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up and tieing up loose ends here 👍

@lzap
Copy link
Member Author

lzap commented Oct 23, 2023

go: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/[email protected]: Get "https://proxy.golang.org/github.com/%21azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/@v/v1.1.1.mod": EOF
make: *** [mk/deps.mk:9: download-deps] Error 1

Network error on the proxy.

/retest

@ezr-ondrej
Copy link
Member

/retest

Another network error, Jenkins is having a day :(

@lzap
Copy link
Member Author

lzap commented Oct 23, 2023

Another one. /retest

@ezr-ondrej
Copy link
Member

/retest

It apparently needs to be on a separate line to work.

@ezr-ondrej ezr-ondrej merged commit 2b44916 into RHEnVision:main Oct 23, 2023
6 checks passed
@ezr-ondrej
Copy link
Member

Thanks @lzap !

@lzap lzap deleted the cve-2023-44487-rev branch October 24, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants