fix(HMS-2757): use transactions for reservations #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
commented
Oct 11, 2023
| }) | ||
|
|
||
| if txErr != nil { | ||
| return fmt.Errorf("pgx tx error: %w", txErr) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
To make things simple and because pgx.Tx and pgx.Pool are incompatible types, I am putting this in tx block although it does not need to be. I think I could have used pgx.Querier or some interface, not sure.
There was a problem hiding this comment.
Nah Querier is not from the pgx package, I would rather not use it. These are two different types.
|
And it works...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During investigation on the linked bug, I noticed this. I am not sure if this is root cause of the problems we currently see on stage, but chances are this is actually caused by the performance testing and throttle limiting.
This needs to be fixed no matter of what.