feat(HMS-2440): private IPv4 address for GCP #704
Conversation
| @@ -10,7 +10,6 @@ X-Rh-Identity: {{identity}} | |||
| "image_id": "https://www.googleapis.com/compute/v1/projects/rhel-cloud/global/images/rhel-9-v20230411", | |||
| "amount": 1, | |||
| "machine_type": "e2-micro", | |||
| "launch_template_id": "{{launch_template_id}}", | |||
There was a problem hiding this comment.
Intentional? Just checking, might be useful.
There was a problem hiding this comment.
Just removed for testing, commited by mistake, thanks for catching that! 🧡
| @@ -316,6 +316,7 @@ func (c *gcpClient) GetInstanceDescriptionByID(ctx context.Context, id, zone str | |||
| instanceId := strconv.FormatUint(instance.GetId(), 10) | |||
| instanceDesc := clients.InstanceDescription{ID: instanceId} | |||
| for _, n := range instance.NetworkInterfaces { | |||
| instanceDesc.PrivateIPv4 = *n.NetworkIP | |||
There was a problem hiding this comment.
Similarly, I would perhaps check for nil unless there is a documentation remark somewhere that this is never unallocated pointer.
|
Can you add example similarly as I did in AWS please? |
ezr-ondrej
force-pushed
the
priv-ip-gcp
branch
from
bbadddc to
0edc54c
Compare
|
I've added example and check for nil pointers :) |
| @@ -316,6 +316,9 @@ func (c *gcpClient) GetInstanceDescriptionByID(ctx context.Context, id, zone str | |||
| instanceId := strconv.FormatUint(instance.GetId(), 10) | |||
| instanceDesc := clients.InstanceDescription{ID: instanceId} | |||
| for _, n := range instance.NetworkInterfaces { | |||
| if n.NetworkIP != nil { | |||
There was a problem hiding this comment.
I suggest to even check for n != nil, but I do not know what documentation says.
| if n.NetworkIP != nil { | |
| if n != nil && n.NetworkIP != nil { |
There was a problem hiding this comment.
It is rare to put nil into slice/map I would not worry too much about thi.
We have a ptr.FromOrEmpty generic helper, can you use that instead?
There was a problem hiding this comment.
I've used the generic helper, but did not fix the range, I guess it'd be very weird to have nil in an array.
There was a problem hiding this comment.
Yeah, this was just a suggestion, we do not have to check necessarily:)
ezr-ondrej
force-pushed
the
priv-ip-gcp
branch
from
0edc54c to
37b3c99
Compare
No description provided.