Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SimpleReminderHandler #519

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix SimpleReminderHandler #519

merged 1 commit into from
Jan 8, 2025

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Jan 8, 2025

  • Fix timestamp generation in SimpleReminderHandler

this-Aditya
this-Aditya approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@this-Aditya this-Aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes. I will also apply these changes to the Kotlin refactor PR.

@this-Aditya this-Aditya merged commit 06d9061 into dev Jan 8, 2025
4 of 5 checks passed
@mpgxvii
Copy link
Member Author

mpgxvii commented Jan 8, 2025

LGTM, thanks for the changes. I will also apply these changes to the Kotlin refactor PR.

Great, thank you!

@this-Aditya this-Aditya deleted the fix/reminder-handler branch January 13, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@this-Aditya this-Aditya this-Aditya approved these changes

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @this-Aditya