Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store effects cleanup & projection siblings serialization #7228

Open
wants to merge 3 commits into
base: build/v2
Choose a base branch
from

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jan 6, 2025

  • Cleanup store effects on VNode destory etc.
  • Serialize all projection siblings. Previously we only added the SERIALIZE flag, which is a bug, because we did not serialize component props that were siblings of the projection
  • Run resource functions within invoke context

@Varixo Varixo self-assigned this Jan 6, 2025
@Varixo Varixo requested a review from a team as a code owner January 6, 2025 12:37
Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: a6492f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo force-pushed the v2-store-effects-cleanup branch from 3a95d94 to dae54f6 Compare January 6, 2025 12:44
@Varixo Varixo marked this pull request as draft January 6, 2025 13:00
@Varixo Varixo force-pushed the v2-store-effects-cleanup branch from dae54f6 to 0403889 Compare January 6, 2025 13:08
@Varixo Varixo force-pushed the v2-store-effects-cleanup branch from a599e06 to a6492f8 Compare January 7, 2025 15:25
@Varixo Varixo marked this pull request as ready for review January 7, 2025 15:36
Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7228
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7228
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7228
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7228

commit: a6492f8

Copy link
Contributor

github-actions bot commented Jan 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a6492f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

1 participant