Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert destructured array's props to signal #7217

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: convert destructured array's props to signal #7217

merged 1 commit into from
Jan 13, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Dec 31, 2024

No description provided.

@Varixo Varixo self-assigned this Dec 31, 2024
@Varixo Varixo requested a review from a team as a code owner December 31, 2024 12:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: decee40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 31, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7217

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7217

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7217

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7217

commit: decee40

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 31, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview decee40

@Varixo Varixo linked an issue Jan 2, 2025 that may be closed by this pull request
[🐞] V2 - “useTask$” only listens for the first change in the client. #7134
Closed
@Varixo Varixo force-pushed the v2-fix-wrapeed-indentifiers branch from 742d83f to 8d499f5 Compare January 2, 2025 13:48
@Varixo Varixo force-pushed the v2-fix-wrapeed-indentifiers branch from 8d499f5 to decee40 Compare January 10, 2025 16:04
@Varixo Varixo requested a review from wmertens January 10, 2025 18:34
wmertens
wmertens approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 66529fc into build/v2 Jan 13, 2025
22 checks passed
@wmertens wmertens deleted the v2-fix-wrapeed-indentifiers branch January 13, 2025 18:32
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Open
@Varixo Varixo mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] V2 - “useTask$” only listens for the first change in the client.
2 participants
@Varixo @wmertens