chore(rust): remove add_side_effects

doesn't seem to have any effect
QwikDev · Dec 22, 2024 · a39f17a · a39f17a
1 parent 4fa4cff
commit a39f17a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 76 deletions.
diff --git a/packages/qwik/src/optimizer/core/src/add_side_effect.rs b/packages/qwik/src/optimizer/core/src/add_side_effect.rs
diff --git a/packages/qwik/src/optimizer/core/src/lib.rs b/packages/qwik/src/optimizer/core/src/lib.rs
@@ -8,7 +8,6 @@
 #[cfg(test)]
 mod test;
 
-mod add_side_effect;
 mod clean_side_effects;
 mod code_move;
 mod collector;

diff --git a/packages/qwik/src/optimizer/core/src/parse.rs b/packages/qwik/src/optimizer/core/src/parse.rs
@@ -5,7 +5,6 @@ use std::hash::Hasher;
 use std::path::{Path, PathBuf};
 use std::str;
 
-use crate::add_side_effect::SideEffectVisitor;
 use crate::clean_side_effects::Treeshaker;
 use crate::code_move::{new_module, NewModuleCtx};
 use crate::collector::global_collect;
@@ -347,14 +346,7 @@ pub fn transform_code(config: TransformCodeOptions) -> Result<TransformOutput, a
 								},
 							));
 						}
-						if matches!(
-							config.entry_strategy,
-							EntryStrategy::Inline | EntryStrategy::Hoist
-						) {
-							program.visit_mut_with(&mut SideEffectVisitor::new(
-								&qwik_transform.options.global_collect,
-							));
-						} else if config.minify != MinifyMode::None && !config.is_server {
+						if config.minify != MinifyMode::None && !config.is_server {
 							// remove all side effects from client, step 2
 							program.visit_mut_with(&mut treeshaker.cleaner);
 							if treeshaker.cleaner.did_drop {