[16.0][IMP] sell_only_by_packaging: support negative rounding when converting packaging qty #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisdoan
reviewed
Jul 22, 2024
Comment on lines
59
to
70
| forced_qty = qty - (qty % q) + q | ||
| # Support negative rounding | ||
| if ( | ||
| float_compare( | ||
| qty, | ||
| 0.0, | ||
| precision_rounding=0.001, | ||
| ) | ||
| < 0 | ||
| ): | ||
| forced_qty = forced_qty - q | ||
| return forced_qty |
There was a problem hiding this comment.
nested-if could make other dev confused
trisdoan
reviewed
Jul 23, 2024
| ) | ||
| < 0 | ||
| ): | ||
| forced_qty = forced_qty - q |
There was a problem hiding this comment.
Suggested change
| forced_qty = forced_qty - q | |
| forced_qty -= q |
trisdoan
approved these changes
Jul 23, 2024
QuocDuong1306
force-pushed
the
16.0-imp-sell_only_by_packaging
branch
from
acd29db to
dfaaf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on upstream, It's possible to support creating return orders when filling negative quantities in product_uom_qty.
This PR will help to round down the product quantities to the nearest multiple of the packaging quantity in that case.