-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WASM] Add WASM lectures config and CI testing #560
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kp992 thanks for thinking this through. I think it would be best if we:
|
@kp992 thanks for putting this together. Should we have an |
@kp992 I am not sure why this is reporting green when there are known failures. Can you explain? |
Thanks for the review @mmcky. The reason is pyodide kernel is unavailable to run with jupyter notebook/lab so there isn't a robust approach to run notebooks on pyodide kernel and test it. So this approach is just checking based on imports. I figured out another solution which is kind a bit hacky but better than the current approach. I didn't prioritize testing because I was focusing fixing the existing issues. Once we are ready will all lectures I can find a better solution for testing. |
No worries @kp992 -- I'll park this for now as it isn't really testing what we are after here. We can focus on the migration as you say. Thanks. |
Related to QuantEcon/meta#143.
This PR introduces the config to add the lectures that are WASM compatible. We will add lectures one by one to this config and they will get reflected automatically in the https://github.com/QuantEcon/project.lecture-wasm.