Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM] Add WASM lectures config and CI testing #560

Closed
wants to merge 5 commits into from
Closed

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Dec 1, 2024

Related to QuantEcon/meta#143.

This PR introduces the config to add the lectures that are WASM compatible. We will add lectures one by one to this config and they will get reflected automatically in the https://github.com/QuantEcon/project.lecture-wasm.

@kp992 kp992 requested a review from mmcky December 1, 2024 21:15
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 9b27407
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/67564e41c31fca0008ab661f
😎 Deploy Preview https://deploy-preview-560--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 1, 2024

@github-actions github-actions bot temporarily deployed to pull request December 1, 2024 21:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 00:54 Inactive
@mmcky
Copy link
Contributor

mmcky commented Dec 3, 2024

@kp992 thanks for thinking this through.

I think it would be best if we:

  • setup wasm.yml and keep this workflow separate to our current CI.

@github-actions github-actions bot temporarily deployed to pull request December 9, 2024 02:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 9, 2024 02:04 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jan 23, 2025

@kp992 thanks for putting this together.

Should we have an environment-wasm.yml file of some kind to enable support for all the scipy stack like pandas etc.?

@mmcky mmcky added the wasm label Jan 24, 2025
@mmcky
Copy link
Contributor

mmcky commented Jan 30, 2025

@kp992 I am not sure why this is reporting green when there are known failures. Can you explain?

@kp992
Copy link
Contributor Author

kp992 commented Jan 31, 2025

Thanks for the review @mmcky. The reason is pyodide kernel is unavailable to run with jupyter notebook/lab so there isn't a robust approach to run notebooks on pyodide kernel and test it. So this approach is just checking based on imports.

I figured out another solution which is kind a bit hacky but better than the current approach. I didn't prioritize testing because I was focusing fixing the existing issues. Once we are ready will all lectures I can find a better solution for testing.

@mmcky
Copy link
Contributor

mmcky commented Jan 31, 2025

No worries @kp992 -- I'll park this for now as it isn't really testing what we are after here. We can focus on the migration as you say. Thanks.

@mmcky mmcky closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants