Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CMAKE_MODULE_PATH for HIP #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhilgema-amd
Copy link

ROCm 6.x has cmake modules installed under ${ROCM_PATH}/lib/cmake. This fixes the cmake configure error:

-- Found HIP: 6.2.41134
-- HIP PATH: /opt/COE_modules/rocm/rocm-6.2.2
CMake Error at CMakeLists.txt:380 (hip_add_library):
  Unknown CMake command "hip_add_library".

ROCm 6.x has cmake modules installed under ${ROCM_PATH}/lib/cmake. This fixes the cmake configure error:

-- Found HIP: 6.2.41134
-- HIP PATH: /opt/COE_modules/rocm/rocm-6.2.2
CMake Error at CMakeLists.txt:380 (hip_add_library):
  Unknown CMake command "hip_add_library".
@TysonRayJones
Copy link
Member

Hi Martin,
Thanks very much for the contribution! The CMake build has been overhauled on the v4 branch which is currently our de facto develop branch, although (afaik) we haven't yet tested HIP deployment. Would you be able to check this patch is still necessary there, and if so, prepare a PR to the v4 branch? We will eventually merge v4 -> develop -> master.
Thanks very much!

@otbrown
Copy link

otbrown commented Jan 31, 2025

My own attempts to reinstate HIP support are currently bashing up against incompatibilities in the complex datatypes, possibly related to this issue 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants