Skip to content

Commit

Permalink
Fix client not exiting via signals (INT/TERM)
Browse files Browse the repository at this point in the history
Fixed by removing extraneous call to System.exit() in Controller.stopAll()

Most callers of Controller.stopAll(), i.e. other classes, also call
System.exit() themselves afterwards.

Controller class also sets up a shutdown hook which calls stopAll()
but the [now removed] extra call to System.exit() inside stopAll()
was blocking and stopping proper shutdown, requiring SIGKILL.
  • Loading branch information
catbref committed Nov 6, 2017
1 parent 02443f4 commit 9cdd6cf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Qora/src/controller/Controller.java
Original file line number Diff line number Diff line change
Expand Up @@ -634,8 +634,6 @@ public void stopAll() {
createDataCheckpoint();

LOGGER.info(Lang.getInstance().translate("Closed."));
// FORCE CLOSE
System.exit(0);
}
}

Expand Down

0 comments on commit 9cdd6cf

Please sign in to comment.