Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kernel/FB] Fix HDMI audio #51

Closed
Qonfused opened this issue Mar 4, 2024 · 0 comments · Fixed by #53
Closed

[Kernel/FB] Fix HDMI audio #51

Qonfused opened this issue Mar 4, 2024 · 0 comments · Fixed by #53
Assignees
@Qonfused
Labels
project:UX481 For variants UX481FA (14", 2019) and UX481FL (14", 2019) status:investigating Issue is currently being investigated. type:bug Something isn't working type:documentation Improvements or additions to documentation

Comments

@Qonfused
Copy link
Owner

Qonfused commented Mar 4, 2024

It's possible that HDMI audio does not work due to an unset power well state. This was discovered from a check that looks for the presence of a connector flag (from the internal display, oddly enough).

This check was found in AppleIntelFramebufferController::getPowerWellState:
https://github.com/acidanthera/WhateverGreen/blob/c5a5f507f54a6ff1d17e048fb9456302ef2a3702/WhateverGreen/kern_fb.hpp#L138-L142:

0x100 // Activates Power Well 2 usage (SKL_PW_CTL_IDX_PW_2)
0x80  // Activates MISC IO power well (SKL_DISP_PW_MISC_IO)

I've previously encountered this in #4 (comment), which brings some related points to this issue (as both audio and DDI_B lanes are within the power domain of PW2).

For HDMI (digital audio), the suggested fix is to change the connector flags for the internal display (con0) from 98000000 to 98010000:

framebuffer-con0-alldata | Data | <00000800 02000000 98010000>
framebuffer-con0-enable  | Data | <01000000>
@Qonfused Qonfused added type:bug Something isn't working type:documentation Improvements or additions to documentation status:investigating Issue is currently being investigated. project:UX481 For variants UX481FA (14", 2019) and UX481FL (14", 2019) labels Mar 4, 2024
@Qonfused Qonfused self-assigned this Mar 4, 2024
@Qonfused Qonfused moved this from Todo to In Progress in Zenbook Duo 14" UX481 Mar 4, 2024
@Qonfused Qonfused moved this from In Progress to Todo in Zenbook Duo 14" UX481 Mar 4, 2024
Qonfused added a commit that referenced this issue Mar 20, 2024
@Qonfused
Fix HDMI audio (#51)
21f37f7 
Closes #51, adding the 0x100 connector flag to the internal connector. This enables usage of power well 2, as HDMI and DP audio are connected to it's power domain.
@Qonfused Qonfused linked a pull request Mar 20, 2024 that will close this issue
Add support for macOS Sonoma #53
Merged
Qonfused added a commit that referenced this issue Mar 25, 2024
@Qonfused
Add support for macOS Sonoma (#53)
6b75635 
* Docs: Add README resources for Sonoma

* README: Update build instructions, fix Continuity features list

* Add AirportItlwm versions for Sonoma

* Bumped OpenCore to v0.9.9

* Fix HDMI audio (#51)
@github-project-automation github-project-automation bot moved this from Todo to Done in Zenbook Duo 14" UX481 Mar 25, 2024
@Qonfused Qonfused mentioned this issue Jul 24, 2024
Open
Qonfused added a commit to Qonfused/ASUS-ZenBook-Pro-Duo-15-UX581-Hackintosh that referenced this issue Jul 25, 2024
@Qonfused
Fix HDMI/DP audio
20bf862 
Adds the `0x100` connector flag to the internal connector. This enables usage of power well 2, as HDMI and DP audio are connected to it's power domain.

See Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Qonfused Qonfused

Labels
project:UX481 For variants UX481FA (14", 2019) and UX481FL (14", 2019) status:investigating Issue is currently being investigated. type:bug Something isn't working type:documentation Improvements or additions to documentation
Projects
Zenbook Duo 14" UX481
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for macOS Sonoma Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh
1 participant
@Qonfused