Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creaking configs #1613

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Add Creaking configs #1613

merged 4 commits into from
Nov 26, 2024

Conversation

Onako2
Copy link
Contributor

@Onako2 Onako2 commented Nov 25, 2024

Checklist:

  • Add Rideables config
  • Add attributes such as scale

creaking_transient doesn't support riding. Even when I tried forcefully putting the player on a creaking_transient the player would desync. Creaking Transient will be removed anyway in 1.21.4.

@Onako2 Onako2 marked this pull request as ready for review November 25, 2024 20:49
patches/server/0007-Ridables.patch Outdated Show resolved Hide resolved
patches/server/0007-Ridables.patch Outdated Show resolved Hide resolved
@Onako2 Onako2 requested a review from granny November 26, 2024 11:24
Copy link
Member

@granny granny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Will be merged once a PR is made to PurpurDocs with the new options.

@granny granny added the needs-docs A pull request to PurpurDocs is required before merge label Nov 26, 2024
@Onako2
Copy link
Contributor Author

Onako2 commented Nov 26, 2024

Ok, I planned anyway to do a PR to docs lol

@granny granny merged commit 06dde9d into PurpurMC:ver/1.21.3 Nov 26, 2024
1 check passed
@granny granny removed the needs-docs A pull request to PurpurDocs is required before merge label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants