feat: update PUNDIAI and FX #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces enhancements to the mainnet upgrade process for the Pundi AI token. The changes focus on adding a new constant for the mainnet bridge token, creating a function to retrieve the bridge token address, and modifying the upgrade logic to include a new function Changes
Sequence DiagramsequenceDiagram
participant Ctx as SDK Context
participant Keeper as ERC20 Keeper
participant Upgrade as Upgrade Handler
Upgrade->>Ctx: Call updateMainnetPundiAI
Ctx->>Ctx: migrateErc20FXToPundiAI
Ctx->>Ctx: updateFXBridgeDenom
Ctx->>Keeper: addMainnetPundiAIBridgeToken
Keeper-->>Ctx: Bridge Token Added
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
app/upgrades/v8/constants.go (1)
83-88: Consider a more graceful error handling approach.Instead of panicking for invalid chain IDs, consider:
- Returning an error that can be handled by the caller.
- Adding logging before the panic for better debugging.
func getMainnetBridgeToken(ctx sdk.Context) common.Address { if ctx.ChainID() == fxtypes.MainnetChainId { return common.HexToAddress(mainnetPundiAIToken) } - panic("invalid chain id") + ctx.Logger().Error("invalid chain id for mainnet bridge token", "chain_id", ctx.ChainID()) + panic(fmt.Sprintf("invalid chain id: %s, expected: %s", ctx.ChainID(), fxtypes.MainnetChainId)) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/upgrades/v8/constants.go(1 hunks)app/upgrades/v8/erc20.go(1 hunks)app/upgrades/v8/upgrade.go(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Mergify Merge Protections
- GitHub Check: Summary
🔇 Additional comments (1)
app/upgrades/v8/erc20.go (1)
51-54: Verify bridge token addition and its impact.The function adds a bridge token for mainnet PundiAI. Please ensure:
- The bridge token addition won't affect existing token holders.
- The
falseflag inAddBridgeTokenis the intended value for token registration.Run this script to check existing bridge tokens and verify no conflicts:
✅ Verification successful
Bridge token addition verified as safe
The implementation has been verified and:
- Adding bridge token only creates a mapping entry and doesn't affect existing token holders
- The
falseflag is the correct value for bridge tokens from external chains- No conflicts found with existing bridge token registrations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check existing bridge tokens to avoid conflicts # Test: Search for bridge token registrations. Expect: No conflicts with PundiAI token. echo "Checking bridge token registrations..." rg -A 5 "AddBridgeToken.*DefaultDenom.*ModuleName" echo "Checking bridge token usage..." ast-grep --pattern 'GetBridgeToken($ctx, $module, $denom)'Length of output: 431
Script:
#!/bin/bash # Search for all bridge token related configurations and implementations echo "Checking all AddBridgeToken calls..." rg -A 5 "AddBridgeToken" echo "Searching for AddBridgeToken implementation..." ast-grep --pattern 'func ($receiver) AddBridgeToken($ctx, $denom, $module, $token, $enable) $ret' echo "Checking for existing PundiAI configurations..." rg -i "pundiai"Length of output: 111282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores