test: add sendToFxClaim unit test

[zakir-code]

Summary by CodeRabbit

• New Features

  • Added UnpackEvent method for parsing Ethereum log events in crosschain module
  • Enhanced test coverage for ExecuteClaim functionality with new test cases

• Tests

  • Added comprehensive test suite for ExecuteClaim method
  • Expanded test scenarios for different token types and crosschain interactions

• Refactor

  • Updated bridge token handling logic in SwapBridgeToken method
  • Streamlined token denomination management in crosschain module

• Chores

  • Removed unused message server setup in keeper test suite

[coderabbitai]

Walkthrough

This pull request introduces modifications across several files in the crosschain module, focusing on improving token handling, event unpacking, and test coverage. The changes primarily involve updates to the AddBridgeToken method, introducing a new UnpackEvent method for log events, expanding test cases for ExecuteClaim, and making minor adjustments to keeper and test suite configurations. The modifications aim to enhance the robustness and flexibility of bridge token management and crosschain interactions.

Changes

File	Change Summary
precompiles/crosschain/contract_test.go	Updated AddBridgeToken method logic, introducing baseDenom and modifying error handling for native coin and ERC20 token registration
precompiles/crosschain/execute_claim.go	Added new UnpackEvent method to ExecuteClaimABI for parsing Ethereum log events
precompiles/crosschain/execute_claim_test.go	Added comprehensive TestContract_ExecuteClaim_SendToFx test function with multiple test cases for token scenarios
x/crosschain/keeper/keeper_test.go	Removed commented-out msgServer field and related initialization code
x/crosschain/keeper/many_to_one.go	Modified coin transfer line to use defBridgeToken.BridgeDenom() instead of defBridgeToken.Denom

Sequence Diagram

sequenceDiagram
    participant User
    participant CrosschainContract
    participant ExecuteClaim
    participant BridgeModule

    User->>CrosschainContract: Send Token
    CrosschainContract->>ExecuteClaim: Trigger ExecuteClaim
    ExecuteClaim->>ExecuteClaim: Unpack Event
    ExecuteClaim->>BridgeModule: Transfer Token
    BridgeModule-->>User: Confirm Transfer

Loading

Possibly related PRs

• test: bridge call integration test #583: Changes to AddBridgeToken method and bridge token management
• fix: nightly test #594: Updates to crosschain test suite for token processing
• fix: crosschain with origin token #884: Updates to bridge token handling logic

Suggested Labels

automerge

Suggested Reviewers

• fx0x55

Poem

🐰 Bridging tokens with grace and might,
Crosschain magic takes its flight!
Events unpacked, tests refined,
A rabbit's code, precisely designed!
Hop along the blockchain's bright way! 🌉

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

precompiles/crosschain/execute_claim_test.go (1)

47-132: LGTM! Well-structured test cases with comprehensive coverage.

The test suite effectively covers various token scenarios with clear setup and assertions.

Consider adding negative test cases to validate error handling, such as:

• Invalid event nonce
• Non-existent bridge token
• Insufficient balance

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6f8d6d and b4391e0.

📒 Files selected for processing (5)

• precompiles/crosschain/contract_test.go (1 hunks)
• precompiles/crosschain/execute_claim.go (2 hunks)
• precompiles/crosschain/execute_claim_test.go (2 hunks)
• x/crosschain/keeper/keeper_test.go (0 hunks)
• x/crosschain/keeper/many_to_one.go (1 hunks)

💤 Files with no reviewable changes (1)

• x/crosschain/keeper/keeper_test.go

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test
• GitHub Check: lint
• GitHub Check: analyze
• GitHub Check: main
• GitHub Check: Mergify Merge Protections
• GitHub Check: Summary

🔇 Additional comments (4)

precompiles/crosschain/execute_claim.go (1)

97-106: LGTM! Clean implementation of event unpacking.

The UnpackEvent method is well-implemented with proper error handling and follows Go idioms.

precompiles/crosschain/contract_test.go (1)

119-136: LGTM! Improved token denomination handling.

The changes improve maintainability by:

• Adding clear handling for legacy FX denomination
• Better scoping of variables in conditional blocks
• Clearer separation between native coins and ERC20 tokens

precompiles/crosschain/execute_claim_test.go (1)

134-191: LGTM! Thorough test execution and verification.

The test execution includes comprehensive verification of:

• Event emission and content
• Module balances
• Receiver balances
• ERC20 token balances

x/crosschain/keeper/many_to_one.go (1)

37-37: LGTM! Consistent bridge token denomination usage.

The change to use BridgeDenom() aligns with the bridge token handling pattern used throughout the codebase.