Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename functionx to pundiai #828

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore: rename functionx to pundiai #828

merged 1 commit into from
Dec 25, 2024

Conversation

zakir-code
Copy link
Contributor

@zakir-code zakir-code commented Dec 25, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Support for Solidity contract bridge calls.
    • Automatic refund mechanisms and a new bridgeCallback interface.
    • Pending pool for low liquidity scenarios.
    • New governance proposals: MsgUpdateStore and MsgUpdateSwitchParams.
  • Bug Fixes

    • Resolved issues preventing zero gas attacks on EVM transactions.
    • Fixed state rollback error in precompiled contracts.
  • Documentation

    • Updated links and branding from FunctionX to Pundi AIFX across various documentation files.

Copy link

coderabbitai bot commented Dec 25, 2024

Walkthrough

This pull request represents a comprehensive rebranding effort, transitioning the project from "FunctionX" to "Pundi AIFX". The changes span multiple files across the repository, including workflow configurations, Dockerfiles, documentation, and module dependencies. The modifications primarily involve updating repository URLs, image names, license information, and documentation links to reflect the new organizational branding. The core functionality of the project remains unchanged, with the updates focusing on renaming and redirecting references.

Changes

File Change Summary
.github/workflows/docker.yml Updated Docker image names from functionx to pundiai for fxcore, cosmovisor_lite, and cosmovisor jobs
.goreleaser.yml Updated repository URL and Docker image references from functionx to pundiai
LICENSE Updated copyright notice from "FunctionX authors" to "PundiAI authors"
Makefile Changed Docker image tag to ghcr.io/pundiai/fx-core:latest
README.md Updated shield badges and application name to reflect Pundi AIFX branding
cmd/root.go Modified application description to "Pundi AIFX BlockChain App"
cosmovisor.Dockerfile Updated base image to ghcr.io/pundiai/fxcorevisor:7.5.1
cosmovisor_lite.Dockerfile Updated base image to ghcr.io/pundiai/fx-core:7.5.1
docs/README.md Updated SDK and documentation links to Pundi repositories
docs/openapi/openapi.yaml Updated license URL to Pundi repository
go.mod Changed module replacements for go-ethereum and ethermint
scripts/* Updated repository references in various scripts

Possibly related PRs

Poem

🐰 A Rabbit's Rebranding Rhyme 🚀

From FunctionX to Pundi's might,
We hop and change with pure delight!
New badges, links, and Docker's call,
A transformation touching all!
Our code leaps forward, bright and free! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
.goreleaser.yml (1)

110-110: Repository and Docker image references updated correctly.

The Git clone URL and Docker pull commands have been consistently updated to use the pundiai namespace.

Fix trailing spaces in the release footer:

-    git clone https://github.com/pundiai/fx-core.git 
+    git clone https://github.com/pundiai/fx-core.git
-    
+
-    docker pull ghcr.io/pundiai/fx-core:{{ .Version }} 
+    docker pull ghcr.io/pundiai/fx-core:{{ .Version }}
-    
+
-    docker pull ghcr.io/pundiai/fxcorevisor:{{ .Version }} 
+    docker pull ghcr.io/pundiai/fxcorevisor:{{ .Version }}

Also applies to: 118-118, 122-122

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4efd2e4 and e706912.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (14)
  • .github/workflows/docker.yml (3 hunks)
  • .goreleaser.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • LICENSE (1 hunks)
  • Makefile (1 hunks)
  • README.md (3 hunks)
  • cmd/root.go (1 hunks)
  • cosmovisor.Dockerfile (1 hunks)
  • cosmovisor_lite.Dockerfile (1 hunks)
  • docs/README.md (2 hunks)
  • docs/openapi/openapi.yaml (1 hunks)
  • go.mod (1 hunks)
  • scripts/protoc-swagger-gen.sh (1 hunks)
  • scripts/release-note.sh (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • scripts/release-note.sh
  • LICENSE
  • Makefile
  • docs/openapi/openapi.yaml
  • docs/README.md
🧰 Additional context used
🪛 LanguageTool
README.md

[style] ~5-~5: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1140 characters long)
Context: ...ub.com/pundiai/fx-core/releases/latest) License API Reference Go Report Card Go Tests/Lint [![CodeQL](https://github.com/pundiai/fx-c...

(EN_EXCESSIVE_EXCLAMATION)

🪛 yamllint (1.35.1)
.goreleaser.yml

[error] 114-114: trailing spaces

(trailing-spaces)


[error] 116-116: trailing spaces

(trailing-spaces)


[error] 120-120: trailing spaces

(trailing-spaces)

🔇 Additional comments (6)
cmd/root.go (1)

84-84: Change aligns with rebranding efforts.

The updated short description "Pundi AIFX BlockChain App" accurately reflects the project's new naming. No issues detected.

cosmovisor.Dockerfile (1)

13-13: Confirm availability of the new base image.

The version bump and rebranding from functionx to pundiai is consistent with the PR objectives. However, please verify that ghcr.io/pundiai/fxcorevisor:7.5.1 is accessible and stable.

cosmovisor_lite.Dockerfile (1)

13-13: Check the new base image reference.

The switch to ghcr.io/pundiai/fx-core:7.5.1 is aligned with the rebranding. Ensure the new image version is tested and free from regressions.

README.md (1)

5-11: Shield badges updated correctly for rebranding.

All badge URLs have been consistently updated to point to the new pundiai repository.

🧰 Tools
🪛 LanguageTool

[style] ~5-~5: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1140 characters long)
Context: ...ub.com/pundiai/fx-core/releases/latest) License API Reference Go Report Card Go Tests/Lint [![CodeQL](https://github.com/pundiai/fx-c...

(EN_EXCESSIVE_EXCLAMATION)

CHANGELOG.md (1)

348-349: LGTM! Well-documented bug fixes.

The bug fixes are properly documented with clear references to GitHub issues.

go.mod (1)

272-273: Verify fork maintenance and compatibility.

The replacement directives have been updated to use PundiAI's forks:

  1. go-ethereum: github.com/pundiai/go-ethereum
  2. ethermint: github.com/pundiai/ethermint

Please ensure that:

  1. These forks are properly maintained
  2. All necessary upstream changes are regularly synchronized
  3. The specific versions referenced are stable and tested

Run this script to verify the forks and their versions:

✅ Verification successful

Fork maintenance and compatibility verification completed

Based on the repository checks:

  1. Both forks exist and are actively maintained:

    • pundiai/go-ethereum is actively maintained with recent releases (up to v1.14.5)
    • pundiai/ethermint shows active development with multiple release branches
  2. The specific versions referenced in go.mod:

    • go-ethereum: v1.10.20-0.20240425065928-ebb09502e7a7 corresponds to a commit in the release/v1.11.x branch
    • ethermint: v0.6.1-0.20241022071115-5e0afc7c501c aligns with the fxcore/v0.23.x branch

The forks show regular updates and maintenance, with proper version control and release management. The repositories maintain proper documentation and follow standard development practices.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and accessibility of the forked repositories and their versions

# Check if the repositories exist and are accessible
echo "Checking repository accessibility..."
gh repo view pundiai/go-ethereum
gh repo view pundiai/ethermint

# Get the latest commits for the specified versions
echo "Checking version commits..."
gh api repos/pundiai/go-ethereum/commits/v1.10.20-0.20240425065928-ebb09502e7a7
gh api repos/pundiai/ethermint/commits/v0.6.1-0.20241022071115-5e0afc7c501c

Length of output: 23833


Script:

#!/bin/bash
# Let's try a different approach to verify the repositories and their versions

# Check if the repositories exist and their branches/tags
echo "Checking repository branches and tags..."
gh api repos/pundiai/go-ethereum/branches
gh api repos/pundiai/go-ethereum/tags

echo "Checking ethermint repository..."
gh api repos/pundiai/ethermint/branches
gh api repos/pundiai/ethermint/tags

# Let's also check the go.mod file for any other related dependencies
echo "Checking go.mod for related dependencies..."
cat go.mod | grep -A 5 -B 5 "pundiai"

Length of output: 39210

scripts/protoc-swagger-gen.sh Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@zakir-code zakir-code merged commit 6ac55b1 into main Dec 25, 2024
16 checks passed
@zakir-code zakir-code deleted the zakir/pundiai branch December 25, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant