-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename functionx to pundiai #828
Conversation
WalkthroughThis pull request represents a comprehensive rebranding effort, transitioning the project from "FunctionX" to "Pundi AIFX". The changes span multiple files across the repository, including workflow configurations, Dockerfiles, documentation, and module dependencies. The modifications primarily involve updating repository URLs, image names, license information, and documentation links to reflect the new organizational branding. The core functionality of the project remains unchanged, with the updates focusing on renaming and redirecting references. Changes
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.goreleaser.yml (1)
110-110
: Repository and Docker image references updated correctly.The Git clone URL and Docker pull commands have been consistently updated to use the pundiai namespace.
Fix trailing spaces in the release footer:
- git clone https://github.com/pundiai/fx-core.git + git clone https://github.com/pundiai/fx-core.git - + - docker pull ghcr.io/pundiai/fx-core:{{ .Version }} + docker pull ghcr.io/pundiai/fx-core:{{ .Version }} - + - docker pull ghcr.io/pundiai/fxcorevisor:{{ .Version }} + docker pull ghcr.io/pundiai/fxcorevisor:{{ .Version }}Also applies to: 118-118, 122-122
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
📒 Files selected for processing (14)
.github/workflows/docker.yml
(3 hunks).goreleaser.yml
(1 hunks)CHANGELOG.md
(1 hunks)LICENSE
(1 hunks)Makefile
(1 hunks)README.md
(3 hunks)cmd/root.go
(1 hunks)cosmovisor.Dockerfile
(1 hunks)cosmovisor_lite.Dockerfile
(1 hunks)docs/README.md
(2 hunks)docs/openapi/openapi.yaml
(1 hunks)go.mod
(1 hunks)scripts/protoc-swagger-gen.sh
(1 hunks)scripts/release-note.sh
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- scripts/release-note.sh
- LICENSE
- Makefile
- docs/openapi/openapi.yaml
- docs/README.md
🧰 Additional context used
🪛 LanguageTool
🪛 yamllint (1.35.1)
.goreleaser.yml
[error] 114-114: trailing spaces
(trailing-spaces)
[error] 116-116: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
🔇 Additional comments (6)
cmd/root.go (1)
84-84
: Change aligns with rebranding efforts.
The updated short description "Pundi AIFX BlockChain App" accurately reflects the project's new naming. No issues detected.
cosmovisor.Dockerfile (1)
13-13
: Confirm availability of the new base image.
The version bump and rebranding from functionx
to pundiai
is consistent with the PR objectives. However, please verify that ghcr.io/pundiai/fxcorevisor:7.5.1
is accessible and stable.
cosmovisor_lite.Dockerfile (1)
13-13
: Check the new base image reference.
The switch to ghcr.io/pundiai/fx-core:7.5.1
is aligned with the rebranding. Ensure the new image version is tested and free from regressions.
README.md (1)
5-11
: Shield badges updated correctly for rebranding.
All badge URLs have been consistently updated to point to the new pundiai repository.
CHANGELOG.md (1)
348-349
: LGTM! Well-documented bug fixes.
The bug fixes are properly documented with clear references to GitHub issues.
go.mod (1)
272-273
: Verify fork maintenance and compatibility.
The replacement directives have been updated to use PundiAI's forks:
- go-ethereum:
github.com/pundiai/go-ethereum
- ethermint:
github.com/pundiai/ethermint
Please ensure that:
- These forks are properly maintained
- All necessary upstream changes are regularly synchronized
- The specific versions referenced are stable and tested
Run this script to verify the forks and their versions:
✅ Verification successful
Fork maintenance and compatibility verification completed
Based on the repository checks:
-
Both forks exist and are actively maintained:
pundiai/go-ethereum
is actively maintained with recent releases (up to v1.14.5)pundiai/ethermint
shows active development with multiple release branches
-
The specific versions referenced in go.mod:
- go-ethereum:
v1.10.20-0.20240425065928-ebb09502e7a7
corresponds to a commit in the release/v1.11.x branch - ethermint:
v0.6.1-0.20241022071115-5e0afc7c501c
aligns with the fxcore/v0.23.x branch
- go-ethereum:
The forks show regular updates and maintenance, with proper version control and release management. The repositories maintain proper documentation and follow standard development practices.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence and accessibility of the forked repositories and their versions
# Check if the repositories exist and are accessible
echo "Checking repository accessibility..."
gh repo view pundiai/go-ethereum
gh repo view pundiai/ethermint
# Get the latest commits for the specified versions
echo "Checking version commits..."
gh api repos/pundiai/go-ethereum/commits/v1.10.20-0.20240425065928-ebb09502e7a7
gh api repos/pundiai/ethermint/commits/v0.6.1-0.20241022071115-5e0afc7c501c
Length of output: 23833
Script:
#!/bin/bash
# Let's try a different approach to verify the repositories and their versions
# Check if the repositories exist and their branches/tags
echo "Checking repository branches and tags..."
gh api repos/pundiai/go-ethereum/branches
gh api repos/pundiai/go-ethereum/tags
echo "Checking ethermint repository..."
gh api repos/pundiai/ethermint/branches
gh api repos/pundiai/ethermint/tags
# Let's also check the go.mod file for any other related dependencies
echo "Checking go.mod for related dependencies..."
cat go.mod | grep -A 5 -B 5 "pundiai"
Length of output: 39210
Summary by CodeRabbit
Release Notes
New Features
MsgUpdateStore
andMsgUpdateSwitchParams
.Bug Fixes
Documentation