-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UpdateUsefuleness in usecase #268
Added UpdateUsefuleness in usecase #268
Conversation
Codecov Report
@@ Coverage Diff @@
## development #268 +/- ##
===============================================
- Coverage 44.41% 44.24% -0.17%
===============================================
Files 29 29
Lines 1664 1704 +40
===============================================
+ Hits 739 754 +15
- Misses 822 841 +19
- Partials 103 109 +6
Continue to review full report at Codecov.
|
…search condition back to the original design.
test function我不確定怎麼寫比較好, 如果有什麼建議都可以提出來 |
LGTM |
另外想問一下,目前的實作方式是不是無法避免其他使用者的刻意留言?也就是說假如有人的留言帶有其他使者的名字以及推噓文符號,是不是那位被提到的使用者在推噓文的時候就會計算到別人的刻意留言? |
目前看起來是這樣, 如果多加個檢查上下箭頭前一個rune是否為 |
我個人認為依照 ptt 現行做法怎樣都會被有心人操弄,因為畢竟寫入推文的時候我們不會刻意去檢查推文是否有含上下箭頭 |
我想的是在寫入的時候, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes