Fix: iOS PsiphonTunnel returning null if file path contains spaces

* Fixes +[NSURL URLWithString:] returning null if file path is not percent-encoded (containing space instead of %20).
Psiphon-Labs · Nov 27, 2024 · 8008912 · 8008912
1 parent a6c5cfa
commit 8008912
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/MobileLibrary/iOS/PsiphonTunnel/PsiphonTunnel/PsiphonTunnel.m b/MobileLibrary/iOS/PsiphonTunnel/PsiphonTunnel/PsiphonTunnel.m
@@ -192,17 +192,20 @@ + (NSURL*)defaultDataRootDirectoryWithError:(NSError**)err {
 
 // See comment in header
 + (NSURL*)homepageFilePath:(NSURL*)dataRootDirectory {
-    return [NSURL URLWithString:GoPsiHomepageFilePath(dataRootDirectory.path)];
+    return [NSURL fileURLWithPath:GoPsiHomepageFilePath(dataRootDirectory.path)
+                      isDirectory:FALSE];
 }
 
 // See comment in header
 + (NSURL*)noticesFilePath:(NSURL*)dataRootDirectory {
-    return [NSURL URLWithString:GoPsiNoticesFilePath(dataRootDirectory.path)];
+    return [NSURL fileURLWithPath:GoPsiNoticesFilePath(dataRootDirectory.path)
+                      isDirectory:FALSE];
 }
 
 // See comment in header
 + (NSURL*)olderNoticesFilePath:(NSURL*)dataRootDirectory {
-    return [NSURL URLWithString:GoPsiOldNoticesFilePath(dataRootDirectory.path)];
+    return [NSURL fileURLWithPath:GoPsiOldNoticesFilePath(dataRootDirectory.path)
+                      isDirectory:FALSE];
 }
 
 // See comment in header