Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perk Copy Update #603

Merged
merged 14 commits into from
Jan 15, 2025
Merged

Perk Copy Update #603

merged 14 commits into from
Jan 15, 2025

Conversation

Mixelz
Copy link
Contributor

@Mixelz Mixelz commented Jun 29, 2024

Big ol copy update for Perks!
Comprised of improving the backend formatting and the rewording/remaking of several perks.
Important to note: There should be no balance changes in this PR, simply reformating and reorganizing existing text.

FRONT END CHANGES

  • Dilated Five Leaf Clover is removed, it's effect is now held by Irish Ants II.
  • Irish Ants II old effect and levels are combined into Irish Ants I. (Total Luck unchanged)
    • To clarify these changes, Irish Ants I is now contains all flat luck modifiers. Irish Ants II cointains the % modifier from Dilated Five Leaf Clover.
  • 131 and 269 are removed, instead their effects are now held by a new perk Primal Power!. (For if Plat wants to do further Prime Number chicanery)
  • Eternal Acensions (Sing 1) effect removed, as it was an errored copy dupe of Unlimited Growth.
  • Wording changed for any perks that mentions "ADD Codes", they now mention "Add Special Action" instead.
  • Wording for It all adds up changed, specifically to not duplicate the same X value multiple times.
  • EXALT Vault refers to Exalts as challenges instead of achievements. (It has been this way for years, this annoyed me lol.)
  • Applied above changes to ALL languages, wording changes left in English for new TLs.
    • This includes various small fixes and including text colorization that were previously language specific.

BACK END CHANGES

  • Reformatted json relating to perks to be better organized and not complete 🍝.
    • This includes the removal of the singularity.perkNames class and instead having everything for perks be handled by singularity.perk.xxx.
    • The new structure will be singularity.perks.xxx.name and singularity.perks.xxx.default/hasLevelX instead of singularity.perkNames.xxx and singularity.perks.xxx.otherwise/desc/description/m respectively.
  • Applied above structure changes to all language files. (We should probably cull the unused languages?)

That's all! This PR is just meant to be a copy fix/include text only changes but if there is something egregious that is unknown please let me know as always. 👍

@Mixelz
Copy link
Contributor Author

Mixelz commented Jan 14, 2025

So for some god forsaken reason it github decided to mark the ENTIRE en.json folder as a conflict.
I've gone ahead and rebased my changes into the current version of the file, don't freak out by the large file change because nothing has technically changed at all.

@Pseudonian Pseudonian merged commit c3a61cc into Pseudo-Corp:master Jan 15, 2025
3 checks passed
@Mixelz Mixelz deleted the perk-copy-update branch January 15, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants