Merge pull request #60 from Proof-Of-Humanity/feat/test-suite

fix(PoH): processVouches indexing
Proof-Of-Humanity · Sep 3, 2024 · 22c5d45 · 22c5d45
2 parents 4082bbd + 560d5c2
commit 22c5d45
Show file tree

Hide file tree

Showing 6 changed files with 2,197 additions and 209 deletions.
diff --git a/contracts/ProofOfHumanity.sol b/contracts/ProofOfHumanity.sol
@@ -1215,8 +1215,8 @@ contract ProofOfHumanity is IProofOfHumanity, IArbitrable, IEvidence {
 
             if (applyPenalty) {
                 // Situation when vouching address is in the middle of renewal process.
-                uint256 voucherRequestId = voucherHumanity.requestCount[voucherHumanity.owner] - 1;
-                if (voucherRequestId != 0) voucherHumanity.requests[voucherRequestId].punishedVouch = true;
+                uint256 voucherRequestCount = voucherHumanity.requestCount[voucherHumanity.owner];
+                if (voucherRequestCount != 0) voucherHumanity.requests[voucherRequestCount - 1].punishedVouch = true;
 
                 delete voucherHumanity.owner;
 

diff --git a/contracts/extending-old/ProofOfHumanityExtended.sol b/contracts/extending-old/ProofOfHumanityExtended.sol
@@ -1250,8 +1250,8 @@ contract ProofOfHumanityExtended is IProofOfHumanity, IArbitrable, IEvidence {
             if (applyPenalty) {
                 // Situation when vouching address is in the middle of renewal process.
                 if (voucherHumanity.owner != address(0x0) && block.timestamp < voucherHumanity.expirationTime) {
-                    uint256 voucherRequestId = voucherHumanity.requestCount[voucherHumanity.owner] - 1;
-                    if (voucherRequestId != 0) voucherHumanity.requests[voucherRequestId].punishedVouch = true;
+                    uint256 voucherRequestCount = voucherHumanity.requestCount[voucherHumanity.owner];
+                    if (voucherRequestCount != 0) voucherHumanity.requests[voucherRequestCount - 1].punishedVouch = true;
 
                     delete voucherHumanity.owner;