Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resampling fix #58

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Resampling fix #58

merged 5 commits into from
Oct 21, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Oct 21, 2024

Adapts the resampling code to address upstream changes in Xarray and the animation notebook to work with Xarray and NumPy >= 2.0.

Closes #57

Copy link

github-actions bot commented Oct 21, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: dcd6d92
✅ Deployment Preview URL: https://ProjectPythia.github.io/advanced-viz-cookbook/_preview/58

@kafitzgerald kafitzgerald marked this pull request as draft October 21, 2024 17:47
@kafitzgerald
Copy link
Collaborator Author

The build failure here is unrelated to the fix, but rather something else that's broken.

It looks like it's an issue in the animation notebook. Trying to pin down the issue, but I think it might be some other recent Xarray changes.

@kafitzgerald
Copy link
Collaborator Author

Or rather Xarray interactions w/ NumPy 2.0.2 (may just be Numpy 2+)

@kafitzgerald
Copy link
Collaborator Author

Looks like it's this pydata/xarray#9043

We're passing DataArrays to np.linspace (buried in the Xarray code) via the vmin and vmax params.

@kafitzgerald kafitzgerald marked this pull request as ready for review October 21, 2024 18:38
@kafitzgerald
Copy link
Collaborator Author

@jukent, I think I may have broken the automatic reviewer assignment or maybe it doesn't work for cookbooks. Either way, it doesn't look like folks are getting assigned automatically and I don't have permissions to request a review.

This should address the CI failures though.

@jukent jukent self-requested a review October 21, 2024 18:48
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @kafitzgerald

I don't believe we have automatic reviews for Cookbooks since there is usually a smaller "team" associated with the dev for each one.

@kafitzgerald
Copy link
Collaborator Author

@jukent ah, I see. I saw something in the PR template about it, but I'm guessing that propagated from some Project Pythia templating.

Feel free to merge. I don't have permissions on this.

And if you'd rather not squash-merge, I can clean up the commit history. Just let me know.

@jukent jukent merged commit d392a5d into ProjectPythia:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly builds failing for a few months
2 participants