Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps-realtor: full user interface overhaul additional fixes #271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FrazzIe
Copy link

@FrazzIe FrazzIe commented Jan 6, 2025

Overview

The main purpose of this pull request is to fix any issues that stood out to me during the testing of the user interface overhaul of ps-realtor.

Details

  • Fix "imgs" key being set instead of "extra_imgs" when editing/adding or removing property images in ps-realtor through UpdateImgs event.
  • Fix prematurely granting a potential buyer access to an MLO interior which uses ox-doorlock before the purchase has even been confirmed
  • Remove an unused config option that has 0 references in the codebase ShowCustomizerWhenNoStartingApartment
    • If this is used somewhere please let me know and i'll revert it
  • Change price column to be an unsigned integer, this prevents negative values being stored and doubles the available pricing amount
    • Don't think this is completely necessary, it's a database change, I've added sql script to be ran after the initial one which alters the column for existing setup, without migrations this is probably the best I can do.

UI Changes / Functionality

  • No UI changes, shouldn't affect existing functionality other than allowing higher prices properties I guess.

Testing Steps

  • Did you test the changes you made?

  • Did you test core functionality of the script to ensure your changes do not regress other areas?

  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

  • Run the additional sql script after the initial one (or apply to existing setup)

  • Use ps-realtor to add/delete/change images

@FrazzIe FrazzIe marked this pull request as ready for review January 6, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant