Skip to content

Commit

Permalink
Fix some build issues
Browse files Browse the repository at this point in the history
  • Loading branch information
dhadka committed Dec 25, 2023
1 parent 55c3dd5 commit 3ff1af1
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up JDK 17
- name: Set up Java
uses: actions/setup-java@v2
with:
java-version: 18.0.2
Expand Down
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>3.0.0-M1</version>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.3.0</version>
<executions>
<execution>
<phase>prepare-package</phase>
Expand All @@ -119,6 +122,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.2.2</version>
<configuration>
<outputDirectory>${project.build.directory}/lib</outputDirectory>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion src/packaging/linux-jpackage.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--name ${app.name}
--icon "${project.basedir}/appicon.png"
--icon "${project.basedir}/src/packaging/appicon.png"
--dest "${project.build.directory}"
--main-jar ${project.build.finalName}.jar
--main-class ${main-class}
Expand Down
2 changes: 1 addition & 1 deletion src/packaging/osx-jpackage.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--name ${app.name}
--icon "${project.basedir}/appicon.icns"
--icon "${project.basedir}/src/packaging/appicon.icns"
--dest "${project.build.directory}"
--main-jar ${project.build.finalName}.jar
--main-class ${main-class}
Expand Down

0 comments on commit 3ff1af1

Please sign in to comment.