8150: Address UFS overvolting issue

[remtrik]

UFS3 with UFS2 settings → Successfully boots → Irreversible harm to UFS chip due to overvoltage
UFS2 with UFS3 settings → Doesn't boot → No harm to UFS chip

Based on that, always assume device is UFS3 unless PcdStorageHasUFS3 is set to 0

[n00b69]

@remtrik That's actually a good change because I've seen storage upgrades that also update the ufs e.g LG with UFS 3.1

[remtrik]

@remtrik That's actually a good change because I've seen storage upgrades that also update the ufs e.g LG with UFS 3.1

LGs with such upgrade will now require a separate UEFI, because PcdHasUFS3 is 0 on all LG devices

[n00b69]

@remtrik I assume that's automatically getting updated eventually anyways, whenever the next update may come

[gus33000]

QC Stock firmware does indeed dynamically set the PUS3 variable upon detection of an UFS version 3 or higher; this is done by UFSDxe registering event call backs for the ACPI AML Patch protocol, and is implemented on XBL baselines from 2021-02-18 to today. Most devices however would be using an older baseline.

For now this workaround is more than suitable.

[gus33000]

The following is a pseudocode and not real code (location: UFSDxe entry point on modern baselines):

if (UFSInformatioNStructure.UFSSpecificationVersion >= 0x300 && (0 == AsciiStrCmp("WP", OsTypeString))) {
    gBS->CreateEvent(EVT_NOTIFY_SIGNAL, TPL_CALLBACK, AMLProtocolRegistration, NULL, &AMLProtocolRegistrationHandle);
    gBS->RegisterProtocolNotify(&gQcomAcpiPlatformProtocolGuid, AMLProtocolRegistrationHandle, &AMLProtocolRegistrationToken);
}

[gus33000]

It appears the UFSInformationStructure var is retrievable by end consumers by using the EFI_MEM_CARDINFO_PROTOCOL EFI protocol installed by UFSDxe itself, this might be doable by:

Writing code in the ACPI lib to look for such protocol;
request the information via it
if >= 0x300, set value to 1, otherwise 0

[gus33000]

Lets merge this first and look into this later. We have the Daniel update to prepare afterall.

[remtrik]

It appears the UFSInformationStructure var is retrievable by end consumers by using the EFI_MEM_CARDINFO_PROTOCOL EFI protocol installed by UFSDxe itself, this might be doable by:

Writing code in the ACPI lib to look for such protocol; request the information via it if >= 0x300, set value to 1, otherwise 0

Something like this probably would have to be implemented for newer platforms at some point, since some OEMs like Xiaomi and OPPO started making models with different UFS versions based on memory configuration. As for the older platforms, we need to check if what you suggested is actually appliable, I checked UFSDxe on my POCO X3 Pro and POCO X3 NFC and they seem to lack anything that resembles UFS specification in so called UFSInformationStructure. They do however check it but don't save the result anywhere.