Switchsettings #71
Merged
Switchsettings #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Master to 0.3.0
…upKeepStatus to just keepStatus
…e because the test was an or where it should have been an and.
…d renamed them to be lowercase at the beginning
…database were it was renamed as well
… problems with the .type in Scala
…ommand. In case of an exception the exception gets returned.
Instead of assuming that a command with no return was successful it will now fail without a return. In case the return is an exception it will now send a Websocket error message. And now it also support sending a success Fail response.
…s a parameter instead of a separate file.
This is so that it can be modified when the switch needs to be exchanged. This may be changed in the future if we encounter performance issues with the map.
because they are needed for the new functions that we are implementing in the web GUI. And because to delete or change a Device you had to shutdown the Server and manually edit the H2 database or just deleted the database and just setup everything again.
Currently it handles only change the config of a switch.
RaHoni
added
enhancement
maximiliani
approved these changes
Mar 1, 2021
| `state` decimal(5,4) NOT NULL, | ||
| `keepState` boolean NOT NULL, | ||
| `keepstate` boolean NOT NULL, |
There was a problem hiding this comment.
WHY?!!! Why do you changed away from camelCase?
There was a problem hiding this comment.
Simply because it gave weird errors were the higher level API made it to something like keep_state so this was the easiest way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to change the config of a switch via the GUI
One of the Pages for #23