Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrismNavigation,ModalNavigation,NonModalNavigation and NavigationWith… #2

Closed

Conversation

fahadullahsardar
Copy link

…TabbedPage implemented

@@ -11,7 +11,7 @@ jobs:
fail-fast: false
matrix:
solution-path: [
'sample-template',
'01-PrismNavigation','02-ModalNavigation','03-NonModalNavigation','04-NavigationWithTabbedPage','sample-template'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'01-PrismNavigation','02-ModalNavigation','03-NonModalNavigation','04-NavigationWithTabbedPage','sample-template'
'01-PrismNavigation',
'02-ModalNavigation',
'03-NonModalNavigation',
'04-NavigationWithTabbedPage',
'sample-template'

Comment on lines +47 to +54
<ItemGroup>
<MauiXaml Update="Views\MainPage.xaml">
<Generator>MSBuild:Compile</Generator>
</MauiXaml>
<MauiXaml Update="Views\SecondPage.xaml">
<Generator>MSBuild:Compile</Generator>
</MauiXaml>
</ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

<Application xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:local="clr-namespace:_01_PrismNavigation"
x:Class="_01_PrismNavigation.App">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot take this PR because the Sample Template was not used

@dansiegel dansiegel closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants