-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utilities: Allow Numpy warnings from numpy.exceptions #3173
Open
jvesely
wants to merge
1
commit into
PrincetonUniversity:devel
Choose a base branch
from
jvesely:devel-numpy
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
Numpy 1.25.0 moved warnings and errors to a submodule[0]. Moreover, they are removed from the top level namespace in later versions of Numpy. Add and use exception import that either points to the new exception submodule, or the global namespace depending on whether the former is available. [0] https://numpy.org/doc/2.1/release/1.25.0-notes.html#numpy-now-has-an-np-exceptions-namespace Signed-off-by: Jan Vesely <[email protected]>
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
kmantel
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 1.25.0 moved warnings and errors to a submodule[0]. Moreover, they are removed from the top level namespace in later versions of Numpy[1].
Add and use exception import that either points to the new exception submodule, or the global namespace depending on whether the former is available.
[0] https://numpy.org/doc/2.1/release/1.25.0-notes.html#numpy-now-has-an-np-exceptions-namespace
[1] https://numpy.org/doc/2.1/release/2.0.0-notes.html#numpy-2-0-python-api-removals