-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise training script to update model #41
Conversation
ddb581b
to
129f94b
Compare
129f94b
to
103b36d
Compare
Co-authored-by: cmroughan <[email protected]>
5817c6b
to
ea3e152
Compare
6640513
to
5593f96
Compare
2fd9719
to
bf131ab
Compare
3b95c4c
to
5f6ea94
Compare
6c6b79b
to
67b105b
Compare
c2842b6
to
cea5829
Compare
There's a bug causing the script to crash with a "'NoneType' object has no attribute 'file'" report. It's occurring after the run.py portion -- I think it might be happening in the portion of tasks.py dealing with refreshing model data from the database, though I have not had the time to fully isolate it. Cases where it's occurring:
It does not occur on seg/trans jobs refining on a model but without "overwrite" checked. It also does not occur if an earlier step of the script returns "No best model found". Update:Found the bug in the logs, it is indeed happening in tasks.py around where I thought:
|
I would request adjusting tasks.py and run.py to pass forward information about whether the "overwrite" checkbox is ticked or not. If it is ticked, it would be good to pass that info into upload_best_model() and get_best_model(). The logic This logic is because someone could select some arbitrary model to use as a foundation for refining on and they will still want the resulting model even if its accuracy is lower than the foundation model's. For example, my taking an existing model for Latin and using it to jumpstart training a Greek model -- I don't care if the output Greek model is 96% to the original Latin's 98% because it's a wholly new model for me. But if "overwrite" is checked, then in that use case I am presumably training a Latin model on top of the old Latin model and then I do want to make sure I'm not deleting a older but better model by overwriting on top of it. |
work related to #39 #34 and closing out #15