Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APD link to doc search on Arabic/JA query (#1697) #1732

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

blms
Copy link
Contributor

@blms blms commented Jan 28, 2025

In this PR

Per #1697:

  • Generate a link to the Arabic Papyrology Database when Arabic or JA are entered in the document search query
  • Generate a regex version of a JA-to-Arabic translation for this link, since APD is only in Arabic, and supports regex
  • Show the link at the bottom of the search results if it exists

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (2ed1825) to head (1bdaabc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1732   +/-   ##
========================================
  Coverage    98.95%   98.95%           
========================================
  Files          247      247           
  Lines        16133    16152   +19     
========================================
+ Hits         15965    15984   +19     
  Misses         168      168           

@blms blms merged commit f3f3fe7 into develop Jan 28, 2025
15 checks passed
@blms blms deleted the feature/1697-apd-link branch January 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant