Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related places to place detail page (#1696) #1730

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

blms
Copy link
Contributor

@blms blms commented Jan 28, 2025

In this PR

Per #1696:

  • Adapt Person.related_people into a new Place.related_places, which uses a subset of that functionality to get names and converse names of place-place relationships
  • Show that on the Place Detail page using the styling and logic from Document Detail

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (0a2c987) to head (8caaaa8).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1730   +/-   ##
========================================
  Coverage    98.95%   98.95%           
========================================
  Files          247      247           
  Lines        16090    16133   +43     
========================================
+ Hits         15922    15965   +43     
  Misses         168      168           

@blms blms merged commit 2ed1825 into develop Jan 28, 2025
15 checks passed
@blms blms deleted the feature/1696-place-related-places branch January 28, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant