Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent whitespace from being added around highlights in regex search (#1710) #1718

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

blms
Copy link
Contributor

@blms blms commented Jan 13, 2025

In this PR

Per #1710:

  • Prevent whitespace from being added around highlights in regex search, by not running clean_html on regex search

Notes

clean_html is not useful for regex search since the only html there will be <em> tags. We don't need to worry about malformed HTML there; and clean_html will try to add \n around <em> tags because it is a prettifier.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (d15759c) to head (29e7bb6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1718   +/-   ##
========================================
  Coverage    98.92%   98.92%           
========================================
  Files          245      245           
  Lines        15679    15683    +4     
========================================
+ Hits         15511    15515    +4     
  Misses         168      168           

@blms blms merged commit 0b1831d into develop Jan 13, 2025
15 checks passed
@blms blms deleted the bugfix/1710-regex-whitespace branch January 13, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant