-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some authentication related checks #111
base: dev
Are you sure you want to change the base?
Conversation
This reflects the hot patches on the account server. A couple things:
diff --git a/src/services/nasc/routes/ac.ts b/src/services/nasc/routes/ac.ts
index 1a8c616..d126ed9 100644
--- a/src/services/nasc/routes/ac.ts
+++ b/src/services/nasc/routes/ac.ts
@@ -40,7 +40,7 @@ router.post('/', async (request: express.Request, response: express.Response): P
if (server.maintenance_mode) {
// TODO - FIND THE REAL UNDER MAINTENANCE ERROR CODE. 110 IS NOT IT
- response.status(200).send(nascError('110').toString());
+ response.status(503).send(nascError('101').toString());
return;
}
@@ -112,4 +112,4 @@ async function processServiceTokenRequest(server: HydratedServerDocument, pid: n
});
}
-export default router;
\ No newline at end of file
+export default router; |
d803094
to
d28ccbd
Compare
…se oauth generation
Fix for Invalid Service Token error - Refresh Token Duration same as Access Token
I'm going to be requesting the review of @DaniElectra and @shutterbug2000 specifically on this one, to make sure I didn't leave any holes in these changes. Specifically the latest commit, as it changes how we validate console bans and such This is all I had planned for this PR, once reviewed we can merge. I know the PR message mentioned things like bans and token generation, but that can wait for another PR to keep this one's scope down I have tested this on the Wii U and it seems fine. Have not tested it on the 3DS however |
Resolves #XXX
Changes:
These changes have been hot-patched in the prod servers for a long time now. This PR simply brings them upstream. Changes include:
Basic
auth in some endpointsMarking as draft for now since I hate the way the "check the system type" feature was implemented. It's a hack, and I want to change it. There's also a couple open issues now directly relating to tokens which we may want to implement here first before merging? Unsure, would like some opinions.
[Enhancement]: Store tokens in database #107
[Enhancement]: Make (some) tokens use asymmetric cryptography rather than symmetric cryptography #108
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.