[PAYSHIP-3149] PrestaShop 9 compatibility #1304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3RAZ
force-pushed
the
feat/PAYSHIP-3149
branch
from
b887836 to
1a1d7f0
Compare
L3RAZ
force-pushed
the
feat/PAYSHIP-3149
branch
from
14ae80f to
67e5f16
Compare
seiwan
reviewed
Jan 6, 2025
src/Order/Matrice/CommandHandler/UpdateOrderMatriceCommandHandler.php
Outdated
Show resolved
Hide resolved
src/PayPal/PaymentToken/Query/GetCustomerPaymentTokensQueryHandler.php
Outdated
Show resolved
Hide resolved
kpodemski
reviewed
Jan 15, 2025
seiwan
requested changes
Jan 15, 2025
jolelievre
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Thanks @L3RAZ for this huge work
I have a few questions, sorry if they don't make sens it's probably because I lack knowledge on this module's code 😅
| $this->fundingSourceTranslationProvider = $fundingSourceTranslationProvider; | ||
| $this->configuration = $configuration; | ||
| } | ||
|
|
||
| public function __invoke(AddOrderPaymentCommand $command) { |
There was a problem hiding this comment.
By the way, if you use the AsCommandHandler you shouldn't need to add this __invoke method, but again I'm really aware of this module's architecture and context If the command/query buses are used in FO/legacy context this auto-configuration will probably not work
There was a problem hiding this comment.
I will check if this works on front controllers
L3RAZ
force-pushed
the
feat/PAYSHIP-3149
branch
18 times, most recently
from
5a616a6 to
d10c4f4
Compare
PSebou
reviewed
Jan 30, 2025
L3RAZ
force-pushed
the
feat/PAYSHIP-3149
branch
8 times, most recently
from
015831a to
544f199
Compare
L3RAZ
force-pushed
the
feat/PAYSHIP-3149
branch
from
544f199 to
3a6c1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.