Fix undefined current context and memory leak with non HTTP events #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiwan
commented
Mar 23, 2023
seiwan
commented
- Fix the issue "unable to get on undefined..." due to concurrent requests
- Fix the memory leak issue caused by non HTTP events by managing them with LRU Cache
Rzial
suggested changes
Apr 6, 2023
| @@ -246,6 +246,38 @@ export class MyProvider { | |||
| } | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
We need to talk here about ClsModule since now is mandatory for Context. Also would be nice to have an small description on why we use ClsModule
|
|
||
| @Injectable() | ||
| export class ContextContainer { | ||
| private contexts: Record<string, Context> = {}; | ||
| private contextStack: string[] = []; | ||
| private cache: LRUCache<string, Context>; | ||
|
|
There was a problem hiding this comment.
The id recover process for the context should return an exception if we are not able to get it from the ClsService or the request. This exceptionb should be logged to prevent the user that the lib has been missused
|
|
||
| remove(): void { | ||
| const id = this.cls.getId(); | ||
|
|
There was a problem hiding this comment.
Add remove condition to take in account protocol here.
| return this; | ||
| } | ||
|
|
||
| getCachedValue(key: string | symbol) { | ||
| getCachedValue(key: string | symbol): any { |
There was a problem hiding this comment.
Maybe getCachedValue(key: string | symbol): T?
| private call(name: string, ...args: (string | boolean | symbol)[]): any { | ||
| const currentContext = this.contexts.current(); | ||
|
|
||
| if (currentContext instanceof Promise) { |
| @@ -1,29 +1,45 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
| import { ContextContainer } from './context-container'; | |||
| import { Injectable } from '@nestjs/common'; | |||
| import { Context } from './context'; | |||
|
|
|||
| @Injectable() | |||
| export class CurrentContext { | |||
|
|
||
| @Module({}) | ||
| export class TestModule { | ||
| static forRoot(max: number): DynamicModule { |
There was a problem hiding this comment.
Rename max to something more like lruCacheMaxValue or something more readable
| private readonly contextContainer: ContextContainer, | ||
| private readonly asyncRequestService: AsyncRequestServiceExposer, | ||
| ) { | ||
| this.cache = new LRUCache({ max: 50 }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.