Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include id_shop in the primary key on table psgdpr_consent_lang #230

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lmeyer1
Copy link

@lmeyer1 lmeyer1 commented Feb 29, 2024

Questions Answers
Description? In the table psgdpr_consent_lang, the field id_shop is included in the primary key (see sql/install/psgdpr_consent_lang.sql). The Doctrine/ORM annotations must reflect this. Add id_shop in PK in annotations
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#35521
Sponsor company Société Biblique de Genève
How to test? Run php bin/console doctrine:schema:update --dump-sql before and after. Notice that the incorrect query concerning the PK of psgdpr_consent_lang disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Doctrine ORM annotations in psdgpr are not compatible with multishop activated
4 participants