Fixed undefined array key category_name in statistics #280
Conversation
nicosomb
commented
Sep 10, 2024
nicosomb
commented
| Questions | Answers |
|---|---|
| Description? | Fixed undefined array key category_name in statistics |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Sponsor company | PrestaShop SA |
| How to test? | See #276 (review) |
|
|
||
| foreach ($presentedProduct as $key => $value) { | ||
| if ($key == 'embedded_attributes') { | ||
| $imgDetails = $value['cover']; | ||
| } | ||
| } | ||
| if (!$imgDetails) { | ||
| $imageRetriever = new ImageRetriever($this->context->link); |
There was a problem hiding this comment.
I'm not fan of this line because I already have it line 150.
nicosomb
force-pushed
the
fix-undefined-array-key
branch
from
aa38fb9 to
e6e8c9c
Compare
|
Hello @nicosomb, I tested your PR and I found bug sorry :/ But I can't to reproduce the issue of Florine with the error "Undefined array key category_name" https://www.loom.com/share/7eb1aa91d2f444c0800dca95500cc5c3?sid=6f4ffc33-28d5-4a25-949b-575c4531e88a |
|
@paulnoelcholot I think you must test on 8.0.x or 8.1.x to reproduce this. |
|
@paulnoelcholot you already found this bug in an other pull request, there is an opened issue for that : PrestaShop/PrestaShop#33374 |
|
Bump @PrestaShop/qa-functional please, I need this released so PrestaShop/PrestaShop#36873 can move on. :-) |
|
Hi @nicosomb! I have just test your PR with PrestaShop/PrestaShop#36880 and it's ok! |
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Functional Tests : Enable Tests after #280
