feat(web-analytics): Support screen events in web analytics queries #27242
Conversation
|
Size Change: +52 B (0%) Total Size: 9.43 MB ℹ️ View Unchanged
|
| @@ -559,7 +560,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([ | |||
| } | |||
|
|
|||
| const uniqueUserSeries: EventsNode = { | |||
| event: '$pageview', | |||
| event: featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_FOR_MOBILE] ? '$screen' : '$pageview', | |||
There was a problem hiding this comment.
I'm curious, what's your long term idea for this? What if someone wants to support both mobile and web? This will most likely occur, right?
Is the idea here that they should set up separate projects to handle that - one of them tracking $pageviews and the other $screens?
There was a problem hiding this comment.
We also want to show web analytics for a specific website, rather than across all of your sites, so I think we could combine it with that. If the "site" is a mobile app, then put it in mobile app mode.
There was a problem hiding this comment.
Yeah, that makes sense. This would be pretty easy to add as a toggle at the project level then :)
| @@ -149,7 +149,7 @@ def to_path_scroll_bounce_query(self) -> ast.SelectQuery: | |||
| min(session.$start_timestamp ) AS start_timestamp | |||
| FROM events | |||
| WHERE and( | |||
| events.event == '$pageview', | |||
| or(events.event == '$pageview', events.event == '$screen'), | |||
There was a problem hiding this comment.
Can we add a virtual/computed field to the events Clickhouse table to aid with this? Something akin to a boolean is_pageview_like?
Or, maybe, something we could add to the HogQL translation layer instead? I believe mixing these will become cumbersome
| @@ -149,7 +149,7 @@ def to_path_scroll_bounce_query(self) -> ast.SelectQuery: | |||
| min(session.$start_timestamp ) AS start_timestamp | |||
| FROM events | |||
| WHERE and( | |||
| events.event == '$pageview', | |||
| or(events.event == '$pageview', events.event == '$screen'), | |||
There was a problem hiding this comment.
Because the front end clearly separates the screen vs. pageview UIs, can we split this in the back end as well? This shouldn't be tricky, we just need to check the same FF for that user, right?
| pageview_expr = ast.Or( | ||
| exprs=[ | ||
| ast.CompareOperation( | ||
| op=ast.CompareOperationOp.Eq, left=ast.Field(chain=["event"]), right=ast.Constant(value="$pageview") | ||
| ), | ||
| ast.CompareOperation( | ||
| op=ast.CompareOperationOp.Eq, left=ast.Field(chain=["event"]), right=ast.Constant(value="$screen") | ||
| ), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Same as above, could check the FF to decide between $pageview and $screen
Problem
See https://posthog.slack.com/archives/C05LJK1N3CP/p1735900802399899
I haven't spent enough time on this to get the quality super high - this is definitely a "ship this quickly as it'll tell us what else needs to be improved"
Changes
Change web analytics queries to accept $screen events as well as $pageview events.
Adds a feature flag to hide the normal page tiles and replace them with a screen names tile.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Add some tests on the happy path of overview and stats tile. If we decided to add more mobile-specific tiles we'd need to add some test coverage there.