Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Port: AtomicAutomaton (godot 3.5.1) #1225

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

pedrobaratafernandes
Copy link
Contributor

@pedrobaratafernandes pedrobaratafernandes commented Jan 22, 2025

New Port for Atomic Automaton

Game Information

Submission Requirements

CFW Tests

Ensure your game has been tested on all major CFWs:

  • AmberELEC
  • ArkOS
  • ROCKNIX
  • muOS

Resolution Tests

Test all major resolutions:

  • 480x320
  • 640x480
  • 720x720 (RGB30)
  • Higher resolutions (e.g., 1280x720)

File Structure

  • Your port should have the following structure:
    • portname/
      • port.json
      • README.md
      • screenshot.jpg
      • cover.jpg
      • gameinfo.xml
      • Port Name.sh
      • portname/

Additional Resources

For an in-depth guide on creating a pull request, refer to: PortMaster Game Packaging Guide

@Cebion
Copy link
Collaborator

Cebion commented Jan 22, 2025

https://portmaster.games/packaging.html#testing-requirements

Required Testing Process

  1. Create a testing thread in our #testing-n-dev Discord channel

  2. Test your port on all major CFWs and Standard Resolutions:

    • AmberELEC

    • ArkOS

    • ROCKNIX Panfrost / Malai

    • muOS

    • Knulli (Optional)

    • 480x320 (Optional)

    • 640x480

    • 720x720 (Optional)

    • Higher resolutions (e.g., 1280x720)

  3. Address any feedback from the community testing

Note: Pull Requests submitted without documented testing in the #testing-n-dev channel will not be accepted. This ensures quality and compatibility across our supported devices.

@pedrobaratafernandes
Copy link
Contributor Author

testing thread

tested in:
RG35xx H (H700 640x480) Muos AW
RG 351M AmberELEC

@pedrobaratafernandes
Copy link
Contributor Author

It was tested on most consoles and it works.

fi

source $controlfolder/control.txt
source $controlfolder/device_info.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source $controlfolder/device_info.txt

Not used anymore

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to be named README.md

@@ -0,0 +1,26 @@
## Notes

Atomic Automaton Portmaster Release (https://www.portmaster.games)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you notes and url to the gamepage is missing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to go into README.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this https://portmaster.games/metadata-editor.html

for a proper metadata gameinfo.xml

@pedrobaratafernandes
Copy link
Contributor Author

Changes have been made. Please review again.

Copy link
Collaborator

@Cebion Cebion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there =)


export FRT_NO_EXIT_SHORTCUTS=FRT_NO_EXIT_SHORTCUTS

$ESUDO chmod 666 /dev/uinput
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ESUDO chmod 666 /dev/uinput

Not needed

Check https://portmaster.games/packaging.html#godot-game-example-launchscript

The bottom ones have been replaced wit pm_finish

and pm_platform_helper is needed.

Copy link
Collaborator

@Cebion Cebion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export FRT_NO_EXIT_SHORTCUTS=FRT_NO_EXIT_SHORTCUTS

$GPTOKEYB "$runtime" -c "./AtomicAutomaton.gptk" &
SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig" "$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig" "$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"
pm_platform_helper "$runtime"
SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig" "$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"

export FRT_NO_EXIT_SHORTCUTS=FRT_NO_EXIT_SHORTCUTS

$GPTOKEYB "$runtime" -c "./AtomicAutomaton.gptk" &
SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig" "$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig" "$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"
"$runtime" $GODOT_OPTS --main-pack "AtomicAutomaton.pck"

cd $GAMEDIR

# Set the XDG environment variables for config & savefiles
export XDG_CONFIG_HOME="$CONFDIR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export XDG_CONFIG_HOME="$CONFDIR"
export SDL_GAMECONTROLLERCONFIG="$sdl_controllerconfig"


GAMEDIR=/$directory/ports/atomic_automaton/
CONFDIR="$GAMEDIR/conf/"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> "$GAMEDIR/log.txt" && exec > >(tee "$GAMEDIR/log.txt") 2>&1

Copy link
Collaborator

@Cebion Cebion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw the file structure is wrong.

image

Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file structure is kind of messed-up :

.
└── ports
    └── atomic_automaton
        ├── Atomic Automaton.sh
        └── atomic_automaton
            ├── AtomicAutomaton.gptk
            ├── AtomicAutomaton.pck
            ├── LICENSE.ATOMIC_AUTOMATON.txt
            ├── LICENSE.FRT.txt
            ├── README.md
            ├── atomic_automaton
            │   ├── AtomicAutomaton.gptk
            │   ├── AtomicAutomaton.pck
            │   └── licenses
            │       ├── LICENSE.ATOMIC_AUTOMATON.txt
            │       └── LICENSE.FRT.txt
            ├── gameinfo.xml
            ├── licenses
            │   ├── LICENSE.ATOMIC_AUTOMATON.txt
            │   └── LICENSE.FRT.txt
            ├── port.json
            └── screenshot.jpg

I should be like this

.
└── ports
    └── atomic_automaton
        ├── Atomic Automaton.sh
        ├── README.md
        ├── atomic_automaton
        │   ├── AtomicAutomaton.gptk
        │   ├── AtomicAutomaton.pck
        │   └── licenses
        │       ├── LICENSE.ATOMIC_AUTOMATON.txt
        │       └── LICENSE.FRT.txt
        ├── gameinfo.xml
        ├── port.json
        └── screenshot.jpg

ports/atomic_automaton/Atomic Automaton.sh Outdated Show resolved Hide resolved
Cebion
Cebion previously approved these changes Feb 4, 2025
@Cebion Cebion dismissed cdeletre’s stale review February 4, 2025 14:05

recheck please

Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one line to remove in the launch template and we're good to go :)

ports/atomic_automaton/Atomic Automaton.sh Outdated Show resolved Hide resolved
@cdeletre cdeletre merged commit 94f0bcd into PortsMaster:main Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants