Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sass migrations #4006

Merged
merged 21 commits into from
Nov 23, 2021
Merged

Sass migrations #4006

merged 21 commits into from
Nov 23, 2021

Conversation

Crashillo
Copy link
Contributor

@Crashillo Crashillo commented Nov 15, 2021 •
edited
Loading

Closes #3996
Merge also PopulateTools/gobierto-gencat-engine#27
Merge also https://github.com/PopulateTools/gobierto-pro/pull/2

✌️ What does this PR do?

Fix dart-sass warnings. Run sass-migrator tool:

  • npx sass-migrator division **/*.scss
  • npx sass-migrator module **/*.scss
  • npx sass-migrator namespace **/*.scss

module migration skipped

Pending tasks

  • Deprecate @import in favour of @use
  • Clean for each CSS entrypoint the dependencies (marked as TODOs in the code)

Both gather in #4012

@ferblape
Copy link
Member

Ouch, review the tests

@ferblape ferblape marked this pull request as draft November 16, 2021 14:40
@Crashillo
move styles & images
e9127df 
- remove vendor styles
- load CSS from the JS
- fix relating errors
@Crashillo
fixes on styling
fd14bf1
@Crashillo Crashillo mentioned this pull request Nov 17, 2021
Merged
@Crashillo Crashillo marked this pull request as ready for review November 18, 2021 10:58
ferblape
ferblape requested changes Nov 19, 2021
View reviewed changes
Copy link
Member

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments, all favicons are broken (review the developer console)

The rest looks pretty good 🥳 !!

app/javascript/lib/commons/index.js Outdated Show resolved Hide resolved
app/javascript/lib/commons/index.js Outdated Show resolved Hide resolved
config/application.rb Outdated Show resolved Hide resolved
jorgeatgu
jorgeatgu approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@jorgeatgu jorgeatgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@ferblape
Copy link
Member

@Crashillo can you review the conflicts, please?

@Crashillo Crashillo mentioned this pull request Nov 22, 2021
Merged
14 tasks
@ferblape ferblape merged commit 1485b47 into master Nov 23, 2021
@ferblape ferblape deleted the sass-migrations branch November 23, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferblape ferblape Awaiting requested review from ferblape

@jorgeatgu jorgeatgu Awaiting requested review from jorgeatgu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade sass semantics
3 participants
@Crashillo @ferblape @jorgeatgu