This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Make noAnimations imply noink on the inner paper-ripple. #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102 where animation-free dropdowns ended up
with tons of Ripple objects endlessly and invisibly animating in
requestAnimationFrames, though I'll admit it's not a principled fix,
in that I'm not sure what the root cause of the bug is.
This seems to be roughly in line with user expectations I think, as
someone who doesn't want animations probably also doesn't want a
ripple animation.
I went this route rather than making
noink
work because the noinkproperty isn't mapped anywhere, and the requestAnimationFrame leak
would still occur for people using noAnimations.