This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Preload the font used by .keyboard-focus
#26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +120,12 @@ | |||
| .content { | |||
| padding: 0.7em 0.57em | |||
| } | |||
|
|
|||
| /* preload the font used by `.keyboard-focus` */ | |||
| ::after { | |||
|
Does this actually work? Also, maybe you should run the tests again? Also also, sorry for responding to this so late. Finally 👍 |
|
@blasten Can you rebase this branch, and then reopen the PR? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a button receives focus from the keyboard, the font-face might not be ready (downloaded & decoded). This creates an undesirable visual effect; however, if the font-face is requested ahead in time, we can avoid that effect.
This seems to be the issue in #24
\cc @frankiefu