Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframes in Safari #80

Open
blasten opened this issue Jan 4, 2016 · 4 comments
Open

iframes in Safari #80

blasten opened this issue Jan 4, 2016 · 4 comments

Comments

@blasten
Copy link
Contributor

blasten commented Jan 4, 2016

This is generally problematic in Safari <= 9.0.1. A few issues:

  1. iframe content isn't sized automatically so users can't scroll.
  2. Poor UX in mobile iOS
  3. mousewheel event is not triggered inside an iframe in safari <=8 Fix iframe mouse wheel in safari <= 8 #48, https://bugs.webkit.org/show_bug.cgi?id=124139
  4. This issue is also present in the catalog https://github.com/Polymer/polymer-element-catalog

Proposed solution:

Open the demos in a new window. (aka target="_blank") That will fix all the issues without adding more complexity.

@notwaldorf
Copy link
Contributor

@justinfagnani Please feel free to make this lower priority, but "our demos don't work in Safari" sounds a bit bad.

@justinfagnani
Copy link
Contributor

I'm working through reproducing the issues here.

First up: iframe sizing. I'm seeing the sizing problem on initial load in Safari, but after resize, reload, and after some arbitrary amount of time, the iframe resizes and scrolling works. I'm wondering if this is an issue in iron resizable stuff, but have no context. Thoughts?

@aendra-rininsland
Copy link

I think I'm getting similar behaviour but in Chrome 48, both from the version of iron-component-page included in generator-polymer's seed component (1.1.4 I think) and freshly-installed 1.1.5 — the iframe is set to height 100%, preventing scrolling. It scrolls perfectly if the iframe's height is set to something like 100vh.

@justinfagnani justinfagnani assigned FredKSchott and unassigned blasten Apr 26, 2016
@FredKSchott
Copy link

I dug into this a bit back in April and couldn't nail down a solid reproducible case. Sometimes contents wouldn't scroll, and then on next refresh they would scroll fine.

I'm going to unassign this for now, and we can reassign to myself or someone else once it's prioritized for the time this will take to fix.

@FredKSchott FredKSchott removed their assignment Jun 7, 2016
blasten pushed a commit that referenced this issue Jun 17, 2016
blasten pushed a commit that referenced this issue Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants