Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo crashes on iOS when run in iframe #258

Closed
1 of 6 tasks
kevinpschaaf opened this issue Jun 9, 2016 · 1 comment
Closed
1 of 6 tasks

Demo crashes on iOS when run in iframe #258

kevinpschaaf opened this issue Jun 9, 2016 · 1 comment

Comments

@kevinpschaaf
Copy link
Contributor

Description

Demo crashes on iOS when run in iframe. It would be ideal to understand what triggers the Safari bug and consider ways to mitigate it. In the short term, it might be good to add logic to the demo to pop the demo out of the catalog's demo iframe on iOS, since it reflects poorly on the component, despite it being a Safari bug.

Expected outcome

Demo works.

Actual outcome

Demo crashes Safari.

Steps to reproduce

Open https://elements.polymer-project.org/elements/iron-list?view=demo:demo/index.html&active=iron-list on iOS device

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • [?] Safari 8
  • [?] Safari 7
  • Edge
  • IE 11
  • IE 10
@blasten
Copy link
Contributor

blasten commented Jun 9, 2016

@kevinpschaaf After testing I came to the conclusion that Safari ran out of heap. It seems like iOS Safari limits the memory size for documents loaded on an iframe. In the main demo (demo/index.html) the content size is 317,298px so when the list sets this.$.items.style.height = '317298px'; it crashes. I commented out that line and set it by myself from the console, then it crashed. Also, some of items have a considerable height in that demo, > 1000px That also crashed the tab since those bitmaps probably go over the GPU memory limit... The easiest fix is to remove the iframe from the catalog either in the demo directly or in the catalog for all the demos. (Many of the app-layout and paper-elements demos don't work correctly because of the iframe, see PolymerElements/iron-component-page#80)

blasten pushed a commit that referenced this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 18, 2016
@blasten blasten mentioned this issue Jun 18, 2016
blasten pushed a commit that referenced this issue Jun 20, 2016
blasten pushed a commit that referenced this issue Jun 20, 2016
blasten pushed a commit that referenced this issue Jun 20, 2016
@blasten blasten closed this as completed Jun 20, 2016
Doncaster pushed a commit to Doncaster/iron-list that referenced this issue Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants