-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credential payment api #214
Conversation
Features included are: * 'Buy Now' button added to detail pages when PaymentRequest (PR) is available. * All checkout buttons (e.g., from added-to-cart modal and on /cart) now check for PR and fire if available. * /checkout checks for PR on load and fires if available * Shipping options demonstrate having different options for different locations, including declining to ship outside of US.
1. When user taps "buy now" from item detail 2. When user tries to check out (cart was being erroneously re-initialized)
* Move shop-payment-request to lazy import * Shortend supported payment list (full list set as default) * Declare process-payment event as coming from shop-payment-request
* `shop-payment-request` is a bit more general now (e.g., by decoupling it from the cart's structure and the logic around "Buy Now" vs. "Buy Cart") * `_redirectToCheckout` in `shop-payment-request` no longer causes an app reload. * `shop-payment-request` fires coded `error` events on failure, and redirects for _all_ errors except `Request Cancelled`
Handling exceptions.
…into credentials-payment
Credentials payment
Also fix old usage of a redirect event.
Redirect to /account on successful payment.
- removed iron-localstorage - changed width of `.left-bar-item`
- Load platform.js via google-apis.html - Asychronously load `fetch` polyfill - Replaced Google Sign-In button design - Use `button` instead of `div` for Google Sign-In button
Add Credential Management API and Payment Request API implementations
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
https://cla.developers.google.com/ to signed. |
CLAs look good, thanks! |
Not interested in having these changes in the main |
I will implement it in a real-life example of SHOP. :.-( |
why not?