Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential payment api #214

Closed
wants to merge 33 commits into from
Closed

Credential payment api #214

wants to merge 33 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2018

why not?

Andrew Fitz Gibbon and others added 30 commits August 26, 2016 14:44
Features included are:
* 'Buy Now' button added to detail pages when PaymentRequest (PR) is available.
* All checkout buttons (e.g., from added-to-cart modal and on /cart) now check for PR and fire if available.
* /checkout checks for PR on load and fires if available
* Shipping options demonstrate having different options for different locations, including declining to ship outside of US.
1. When user taps "buy now" from item detail
2. When user tries to check out (cart was being erroneously re-initialized)
* Move shop-payment-request to lazy import
* Shortend supported payment list (full list set as default)
* Declare process-payment event as coming from shop-payment-request
* `shop-payment-request` is a bit more general now (e.g., by decoupling it from the cart's structure and the logic around "Buy Now" vs. "Buy Cart")
* `_redirectToCheckout` in `shop-payment-request` no longer causes an app reload.
* `shop-payment-request` fires coded `error` events on failure, and redirects for _all_ errors except `Request Cancelled`
Handling exceptions.
Also fix old usage of a redirect event.
Redirect to /account on successful payment.
agektmr and others added 3 commits December 14, 2016 16:44
- removed iron-localstorage
- changed width of `.left-bar-item`
- Load platform.js via google-apis.html
- Asychronously load `fetch` polyfill
- Replaced Google Sign-In button design
- Use `button` instead of `div` for Google Sign-In button
Add Credential Management API and Payment Request API implementations
@ghost ghost requested review from frankiefu and keanulee as code owners December 6, 2018 23:55
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ghost
Copy link
Author

ghost commented Dec 17, 2018

https://cla.developers.google.com/ to signed.

@googlebot
Copy link

CLAs look good, thanks!

@keanulee
Copy link
Contributor

Not interested in having these changes in the main master branch, but will keep the credential-payment-api branch around so users can see the changes required (see my opinion at #91 (comment)).

@keanulee keanulee closed this Dec 17, 2018
@ghost
Copy link
Author

ghost commented Dec 19, 2018

I will implement it in a real-life example of SHOP. :.-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants