Add prettier to have consistent formatting across multiple changes #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone!
I thought it might be a very good idea to add prettier to this project so that the JSON files are all formatted the same way no matter who edited them.
This has some advantages to it:
In order to ensure that I added a GitHub action that will automatically run when a new pull request to master/main is created or when directly pushed to main or master.
The workflow would need write permissions to be able to commit the prettified files. This can be enabled in the Repo's settings:
That many changes look scary I know, but they are only showing what the result will be. I could also only add the GitHub workflow configuration file to this PR and let the GitHub action format the files one the next Pull Request that will get merged. This way there will only be one new file added with this Pull Request.
Would love your opinions on this!